ID 362121 - LookFileBake incorrectly triggers `RenamePassInput()` when passes are reordered

Follow

Problem summary:

When panels of a SortablePanel widget are reordered, the SortablePanel widget invokes self.__panelValueChangedCallback(-1) as an update trigger for some derived classes. In the case of the LookFileBake, the event should be discarded, but, instead, it is triggering a RenamePassInput() call with incorrect arguments.

NOTE: The call is actually benign, as further checks inside RenamePassInput() will bail out.

Steps to reproduce:

  • Add a LookFileBake node.
  • Add two passes: pass and pass1.
  • Run the following code in a Python tab in order to provide LookFileBake.RenamePassInput() and LookFileBake.ReorderInput() with some logging:

lookFileBakeNode = NodegraphAPI.GetNode('LookFileBake')lookFileBakeNodeClass = type(lookFileBakeNode)lookFileBakeNodeClass.RenamePassInputOriginal = lookFileBakeNodeClass.RenamePassInputlookFileBakeNodeClass.ReorderInputOriginal = lookFileBakeNodeClass.ReorderInputdef RenamePassInput(self, index, newName):    print("RenamePassInput({0}, {1})".format(index, newName))    self.RenamePassInputOriginal(index, newName)def ReorderInput(self, index, newIndex):    print("ReorderInput({0}, {1})".format(index, newIndex))    self.ReorderInputOriginal(index, newIndex)lookFileBakeNodeClass.RenamePassInput = RenamePassInputlookFileBakeNodeClass.ReorderInput = ReorderInput
  • Move the bottom pass above the top pass.

Actual output:


RenamePassInput(1, pass)ReorderInput(3, 2)

Expected output:


ReorderInput(3, 2)

Tested versions/platforms:

  • 3.0v1 #2310 - Affected

    We're sorry to hear that

    Please tell us why